1469408702 M * Bertl_oO off to bed now ... have a good one everyone! 1469408704 N * Bertl_oO Bertl_zZ 1469410538 J * derjohn_mobi ~aj@x4db24d74.dyn.telefonica.de 1469410979 Q * aj__ Ping timeout: 480 seconds 1469420587 Q * derjohn_mobi Remote host closed the connection 1469425002 J * derjohn_mob ~aj@88.128.80.165 1469426873 J * Ghislain ~aqueos@adsl1.aqueos.com 1469429279 Q * derjohn_mob Ping timeout: 480 seconds 1469432902 J * derjohn_mob ~aj@fw.gkh-setu.de 1469434096 Q * derjohn_mob Remote host closed the connection 1469434715 J * derjohn_mob ~aj@fw.gkh-setu.de 1469434808 Q * derjohn_mob Remote host closed the connection 1469435424 J * derjohn_mob ~aj@fw.gkh-setu.de 1469435513 J * macmaN ~chezburge@90.190.182.21 1469436386 J * tim_ ~quassel@90.63.246.187 1469436766 N * Bertl_zZ Bertl 1469436767 M * Bertl morning folks! 1469436964 M * Ghislain yop 1469437370 M * tim_ Bertl: Hi! I have found a minor issue line 11779 of the 4.1.27-vs2.3.8.5.2 patch (also in previous patches): there is a check to for sk != NULL but it is unnecessary as the sk pointer as already been dereferenced at this point and thus can't be NULL. If you want to keep the check, you need to fix the logic afterwards and introduce a proper error case, otherwise it will fail on the next instruction which dereferences sk. 1469437950 M * Bertl ah, nice, got a patch for me? 1469438638 M * tim_ Bertl: Just remove the if(sk) check at line 11779 in the patch. Do you want a patch against the patch or a patch against the tree patched with vserver? 1469440376 M * Bertl I'd prefer a patch against the tree patched with 4.1.27-vs2.3.8.5.2 1469440989 M * Ghislain you remove a test but what was the test for ? 1469441227 M * Bertl most likely, the purpose of the test was to make sure that sk points to something 1469441423 M * Bertl off for now ... bbl 1469441427 N * Bertl Bertl_oO 1469445673 Q * Aiken Remote host closed the connection 1469447657 M * tim_ Ghislain: the test was to make sure that the sk pointer is not NULL. But this can't happen as it would fail before as this pointer is dereference in the code before. This would also be an upstream bug if this case where to happen. 1469447807 M * Ghislain ok i see thanks for the explanation 1469448152 M * Ghislain but then the interior of the test should be moved before so that the code before if it encounter a null can react ? 1469450364 M * tim_ Bertl, Ghislain: https://paste.kde.org/pcpka5ioe/bsndug 1469451390 Q * derjohn_mob Ping timeout: 480 seconds 1469458579 J * derjohn_mob ~aj@46.189.28.62 1469461623 P * macmaN 1469466626 M * AlexanderS daniel_hozac: Have you seen the pull request on github regarding the systemd-shared-mounts issue? 1469466915 M * Bertl_oO tim_: thanks! 1469467074 M * AlexanderS Bertl_oO: I have a working patch to support writable proc-files: https://gist.github.com/AlexanderS/6506e3d8b71c6bee8938b6faba39c175 Would be nice, if it could be integrated. 1469467104 M * AlexanderS (Maybe with an additional flag like this: https://gist.github.com/AlexanderS/bd65ca5ffae0e11604f0272ddc53a03b) 1469467360 M * Bertl_oO daniel_hozac: what's your opinion on including this into the Linux-VServer patch? 1469467558 M * AlexanderS util-vserver already supports the IATTR_WRITE flag since 2008 (https://github.com/linux-vserver/util-vserver/commit/7ca21845) and there is also support in vprocunhide 1469468811 Q * derjohn_mob Ping timeout: 480 seconds 1469474212 J * derjohn_mob ~aj@p578b6aa1.dip0.t-ipconnect.de 1469480801 J * Aiken ~Aiken@d63f.h.jbmb.net 1469481719 M * Bertl_oO off to bed now ... 1469481720 N * Bertl_oO Bertl_zZ 1469483181 Q * Ghislain Quit: Leaving.