1438992722 M * Bertl_oO undefined: ping? 1438993343 Q * PowerKe Ping timeout: 480 seconds 1438994799 M * undefined Bertl: pong 1438995475 J * PowerKe ~tom@d54C69995.access.telenet.be 1439001168 M * Bertl_oO undefined: ah, well, we recently created a patch to "correct" the accounting error on dlimits (when a file gets overwritten) 1439001221 M * Bertl_oO basically the fix is to "remove" a seemingly unnecessary inode allocation inside the space related block 1439001257 M * Bertl_oO now I have the feeling that this might not have appeared there out of the blue, but instead to "fix" some other issue ... 1439001324 M * Bertl_oO I would really appreciate if you could dig through the irc/mail logs and see if you can find "why" we added this or alternatively show that it was just a patch accident :) 1439001383 M * Bertl_oO this is the patch in question: http://vserver.13thfloor.at/Experimental/delta-dlimit-fix03.diff 1439001444 M * Bertl_oO the change seems to have been introduced around 3.4, but I haven't verified that yet 1439005475 M * Bertl_oO off to bed now ... have a good one everyone! 1439005482 N * Bertl_oO Bertl_zZ 1439006447 Q * gnarface Quit: Leaving 1439006771 J * gnarface ~gnarface@108-227-52-42.lightspeed.irvnca.sbcglobal.net 1439008540 Q * gnarface Quit: Leaving 1439008819 J * gnarface ~gnarface@108-227-52-42.lightspeed.irvnca.sbcglobal.net 1439014257 M * undefined Bertl_zZ: well, the line 'if ((ret = dl_alloc_inode(inode)))' (and it's associated "return ret") wasn't added until 3.18 1439014314 M * undefined it doesn't appear in any 3.14 linux-vserver patches 1439014610 M * undefined but appears in all the 3.18 linux-vserver patches 1439014731 M * undefined okay... 1439014747 M * undefined i haven't even dug into what the code does, but the pattern doesn't look good 1439014799 M * undefined in 3.14... 1439014802 M * undefined in __dquot_alloc_space() we add a call to dl_alloc_space 1439014823 M * undefined in dquot_alloc_inode() we add a call to dl_alloc_inode() 1439014862 M * undefined in __dquot_free_space() we add a call to dl_free_space() 1439014877 M * undefined in dquot_free_inode() we add a call to dl_free_inode() 1439014945 M * undefined makes sense, right? if the function is *_space() we add a call to *_space() and same with *_inode() (we add a call to *_inode()) 1439014970 M * undefined but there's an anomaly in this pattern in 3.18 1439015044 M * undefined we follow the same pattern except for __dquot_alloc_space() where we call both dl_alloc_inode() and dl_alloc_space() 1439015234 M * undefined but testing (by Ghislain, i believe) shows that __dquot_alloc_space() doesn't work unless we remove the it-was-not-there-before-3.18 dl_alloc_inode() 1439015274 M * undefined and calling dl_alloc_inode() within __dquot_alloc_space() doesn't fit the pattern 1439015607 M * undefined yeah, i know that's not solid proof, but just a "bad code smell" 1439015793 M * undefined i find it very suspicious that the change occurred between 3.14 and 3.18 1439015846 M * undefined not between different 3.14 releases or 3.18 releases, as if you had a release, someone discovered a bug, and you added dl_alloc_inode() to __dquot_alloc_space() 1439015877 M * undefined but as if it was introduced when migrating the 3.14 patch to 3.18 1439016405 M * undefined yeah, now that i'm looking at the actual code, it doesn't make sense why we added a call to track the allocation of an *inode* in disklimits inside of a call to track the allocate of *space* in disk quotas 1439016541 M * undefined and i don't see anything in "git diff v3.14 v3.18 fs/quota/dquot.c", specifically in __dquot_alloc_space(), that would hint that the intention/meaning of that function changed upstream and necessitated a change in linux-vserver (like adding a call to dl_alloc_inode inside of it) 1439016564 M * undefined no offense, but i'm thinking "cut and paste" error 1439017979 J * nikolayK ~nkichukov@199.91.137.248 1439021454 J * wicope ~wicope@0001fd8a.user.oftc.net 1439026946 J * bonbons ~bonbons@2001:a18:202:9701:d0a5:fcdf:ff9c:47df 1439031993 Q * wicope Remote host closed the connection 1439032089 N * Bertl_zZ Bertl 1439032092 M * Bertl morning folks! 1439032246 M * Bertl undefined: okay, thanks, so I consider this an error on my side, which makes the patch a proper solution to the problem 1439032269 M * Bertl thanks a lot for digging into it! 1439035160 Q * fstd Remote host closed the connection 1439035171 J * fstd ~fstd@xdsl-84-44-226-7.netcologne.de 1439037275 Q * Aiken Remote host closed the connection 1439042689 J * wicope ~wicope@0001fd8a.user.oftc.net 1439044747 J * Ghislain ~aqueos@adsl1.aqueos.com 1439048929 Q * nikolayK Quit: Leaving 1439050219 M * Bertl off for now ... bbl 1439050227 N * Bertl Bertl_oO 1439051751 J * derjohn_mob ~aj@x590e3ab4.dyn.telefonica.de 1439052205 Q * eyck Ping timeout: 480 seconds 1439056231 J * Aiken ~Aiken@d63f.h.jbmb.net 1439060627 J * eyck ~eyck@u28n61.nowanet.pl 1439066649 P * wicope Leaving 1439066788 Q * fstd Quit: leaving 1439066934 J * fstd ~fstd@xdsl-84-44-226-7.netcologne.de 1439067967 Q * PowerKe charon.oftc.net synthon.oftc.net 1439067967 Q * gamingrobot_ charon.oftc.net synthon.oftc.net 1439067967 Q * ggherdov__ charon.oftc.net synthon.oftc.net 1439067967 Q * sladen charon.oftc.net synthon.oftc.net 1439067967 Q * jrklein charon.oftc.net synthon.oftc.net 1439067967 Q * dustinm` charon.oftc.net synthon.oftc.net 1439067967 Q * mnemoc charon.oftc.net synthon.oftc.net 1439067967 Q * marker charon.oftc.net synthon.oftc.net 1439067967 Q * karasz charon.oftc.net synthon.oftc.net 1439067967 Q * webhat charon.oftc.net synthon.oftc.net 1439067967 Q * jrayhawk charon.oftc.net synthon.oftc.net 1439067967 Q * xdr charon.oftc.net synthon.oftc.net 1439067967 Q * BWare charon.oftc.net synthon.oftc.net 1439067967 Q * undefined charon.oftc.net synthon.oftc.net 1439067967 Q * funnel charon.oftc.net synthon.oftc.net 1439067967 Q * derjohn_mob charon.oftc.net synthon.oftc.net 1439067967 Q * gnarface charon.oftc.net synthon.oftc.net 1439067967 Q * AbyssOne_ charon.oftc.net synthon.oftc.net 1439067967 Q * ntrs charon.oftc.net synthon.oftc.net 1439067967 Q * bragon charon.oftc.net synthon.oftc.net 1439067967 Q * zerick charon.oftc.net synthon.oftc.net 1439068149 J * derjohn_mob ~aj@x590e3ab4.dyn.telefonica.de 1439068149 J * gnarface ~gnarface@108-227-52-42.lightspeed.irvnca.sbcglobal.net 1439068149 J * AbyssOne_ ~jelle3@62.27.85.48 1439068149 J * zerick ~zerick@irc.quassel.zerick.me 1439068149 J * ntrs ~ntrs@vault08.rosehosting.com 1439068149 J * bragon ~alex@tobold.bragon.info 1439068167 J * jrayhawk ~jrayhawk@nursie.omgwallhack.org 1439068167 J * funnel ~funnel@0001c7d4.user.oftc.net 1439068167 J * xdr ~xdr@h56n2-aahm-a11.ias.bredband.telia.com 1439068167 J * BWare ~itsme@31.25.99.5 1439068167 J * undefined ~undefined@00011a48.user.oftc.net 1439068167 J * sladen ~paul@starsky.19inch.net 1439068167 J * karasz ~karasz@00015555.user.oftc.net 1439068167 J * mnemoc ~amery@kwa.jpi.io 1439068167 J * dustinm` ~dustinm`@105.ip-167-114-152.net 1439068167 J * marker marker@server6.org 1439068167 J * webhat ~quassel@31.25.99.5 1439068167 J * gamingrobot_ sid10990@id-10990.highgate.irccloud.com 1439068167 J * jrklein ~cloud@proxy.dnihost.net 1439068167 J * ggherdov__ sid11402@id-11402.ealing.irccloud.com 1439068167 J * PowerKe ~tom@d54C69995.access.telenet.be 1439069275 Q * undefined resistance.oftc.net synthon.oftc.net 1439069275 Q * BWare resistance.oftc.net synthon.oftc.net 1439069275 Q * xdr resistance.oftc.net synthon.oftc.net 1439069275 Q * jrayhawk resistance.oftc.net synthon.oftc.net 1439069275 Q * funnel resistance.oftc.net synthon.oftc.net 1439069275 Q * PowerKe resistance.oftc.net synthon.oftc.net 1439069275 Q * marker resistance.oftc.net synthon.oftc.net 1439069275 Q * karasz resistance.oftc.net synthon.oftc.net 1439069275 Q * sladen resistance.oftc.net synthon.oftc.net 1439069275 Q * mnemoc resistance.oftc.net synthon.oftc.net 1439069275 Q * jrklein resistance.oftc.net synthon.oftc.net 1439069275 Q * gamingrobot_ resistance.oftc.net synthon.oftc.net 1439069275 Q * ggherdov__ resistance.oftc.net synthon.oftc.net 1439069275 Q * dustinm` resistance.oftc.net synthon.oftc.net 1439069275 Q * webhat resistance.oftc.net synthon.oftc.net 1439069285 J * jrayhawk ~jrayhawk@nursie.omgwallhack.org 1439069285 J * funnel ~funnel@0001c7d4.user.oftc.net 1439069285 J * xdr ~xdr@h56n2-aahm-a11.ias.bredband.telia.com 1439069285 J * BWare ~itsme@31.25.99.5 1439069285 J * undefined ~undefined@00011a48.user.oftc.net 1439069285 J * sladen ~paul@starsky.19inch.net 1439069285 J * karasz ~karasz@00015555.user.oftc.net 1439069285 J * mnemoc ~amery@kwa.jpi.io 1439069285 J * dustinm` ~dustinm`@105.ip-167-114-152.net 1439069285 J * marker marker@server6.org 1439069285 J * webhat ~quassel@31.25.99.5 1439069285 J * gamingrobot_ sid10990@id-10990.highgate.irccloud.com 1439069285 J * jrklein ~cloud@proxy.dnihost.net 1439069285 J * ggherdov__ sid11402@id-11402.ealing.irccloud.com 1439069285 J * PowerKe ~tom@d54C69995.access.telenet.be 1439072075 Q * bonbons Quit: Leaving 1439073173 Q * Ghislain Quit: Leaving. 1439073612 J * Ghislain ~aqueos@adsl1.aqueos.com 1439073733 Q * Ghislain 1439074242 J * Ghislain ~aqueos@adsl1.aqueos.com 1439074318 Q * Ghislain 1439074641 Q * undefined synthon.oftc.net charm.oftc.net 1439074641 Q * BWare synthon.oftc.net charm.oftc.net 1439074641 Q * xdr synthon.oftc.net charm.oftc.net 1439074641 Q * jrayhawk synthon.oftc.net charm.oftc.net 1439074641 Q * funnel synthon.oftc.net charm.oftc.net 1439074641 Q * PowerKe magnet.oftc.net synthon.oftc.net 1439074641 Q * marker magnet.oftc.net synthon.oftc.net 1439074641 Q * karasz magnet.oftc.net synthon.oftc.net 1439074641 Q * sladen magnet.oftc.net synthon.oftc.net 1439074641 Q * mnemoc magnet.oftc.net synthon.oftc.net 1439074641 Q * jrklein magnet.oftc.net synthon.oftc.net 1439074641 Q * gamingrobot_ magnet.oftc.net synthon.oftc.net 1439074641 Q * ggherdov__ magnet.oftc.net synthon.oftc.net 1439074641 Q * dustinm` magnet.oftc.net synthon.oftc.net 1439074641 Q * webhat magnet.oftc.net synthon.oftc.net 1439074665 J * undefined ~undefined@00011a48.user.oftc.net 1439074665 J * BWare ~itsme@31.25.99.5 1439074665 J * xdr ~xdr@h56n2-aahm-a11.ias.bredband.telia.com 1439074665 J * funnel ~funnel@0001c7d4.user.oftc.net 1439074665 J * jrayhawk ~jrayhawk@nursie.omgwallhack.org 1439074840 J * Ghislain ~aqueos@adsl1.aqueos.com 1439074918 Q * Ghislain 1439074936 J * PowerKe ~tom@d54C69995.access.telenet.be 1439074936 J * ggherdov__ sid11402@id-11402.ealing.irccloud.com 1439074936 J * jrklein ~cloud@proxy.dnihost.net 1439074936 J * gamingrobot_ sid10990@id-10990.highgate.irccloud.com 1439074936 J * webhat ~quassel@31.25.99.5 1439074936 J * marker marker@server6.org 1439074936 J * dustinm` ~dustinm`@105.ip-167-114-152.net 1439074936 J * mnemoc ~amery@kwa.jpi.io 1439074936 J * karasz ~karasz@00015555.user.oftc.net 1439074936 J * sladen ~paul@starsky.19inch.net 1439075415 J * Ghislain ~aqueos@adsl1.aqueos.com 1439075518 Q * Ghislain 1439076016 J * Ghislain ~aqueos@adsl1.aqueos.com 1439076133 Q * Ghislain 1439076643 J * Ghislain ~aqueos@adsl1.aqueos.com 1439076763 Q * Ghislain 1439077244 J * Ghislain ~aqueos@adsl1.aqueos.com 1439077363 Q * Ghislain 1439077820 J * Ghislain ~aqueos@adsl1.aqueos.com 1439077933 Q * Ghislain 1439078361 Q * fstd Remote host closed the connection 1439078379 J * fstd ~fstd@xdsl-81-173-187-19.netcologne.de